Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI Visibility metadata extraction #2586

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

albertvaka
Copy link
Contributor

What does this PR do?

  • Adds support for the Buddy CI provider
  • Sends env vars used for correlation in the _dd.ci.env_vars tag
  • Reads the CI_JOB_ID and CI_PROJECT_URL env vars in Github

Motivation

This should fix all the discrepancies with the latest spec for CI provider env vars.

* Adds support for the Buddy CI provider
* Sends env vars used for correlation in the _dd.ci.env_vars tag
* Reads the CI_JOB_ID and CI_PROJECT_URL env vars in Github
@albertvaka albertvaka requested a review from a team January 25, 2023 23:31
@github-actions github-actions bot added the ci-app CI product for test suite instrumentation label Jan 25, 2023
Copy link
Contributor

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from CI Vis' perspective

@codecov-commenter
Copy link

Codecov Report

Merging #2586 (61dd877) into master (291dbd2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2586      +/-   ##
==========================================
- Coverage   98.03%   98.03%   -0.01%     
==========================================
  Files        1135     1135              
  Lines       61066    61102      +36     
  Branches     2776     2775       -1     
==========================================
+ Hits        59867    59901      +34     
- Misses       1199     1201       +2     
Impacted Files Coverage Δ
lib/datadog/ci/ext/environment.rb 98.57% <100.00%> (+0.16%) ⬆️
...ec/datadog/tracing/contrib/sidekiq/patcher_spec.rb 96.00% <0.00%> (-4.00%) ⬇️
...dog/profiling/collectors/cpu_and_wall_time_spec.rb 97.48% <0.00%> (-0.42%) ⬇️
...atadog/tracing/contrib/grpc/support/grpc_helper.rb 100.00% <0.00%> (+1.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ivoanjo ivoanjo merged commit b8f4cec into master Jan 26, 2023
@ivoanjo ivoanjo deleted the albertvaka/fix-ci-spec-test branch January 26, 2023 16:27
@github-actions github-actions bot added this to the 1.9.0 milestone Jan 26, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-app CI product for test suite instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants