-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default service_name
values
#2760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarirhamza
changed the title
Change default
Change default Apr 7, 2023
service_name
valuesservice_name
values Part 1
zarirhamza
changed the title
Change default
Change default Apr 7, 2023
service_name
values Part 1service_name
values
TonyCTHsu
reviewed
Apr 11, 2023
TonyCTHsu
reviewed
Apr 11, 2023
spec/datadog/tracing/contrib/http/configuration/configuration_spec.rb
Outdated
Show resolved
Hide resolved
github-actions
bot
added
appsec
Application Security monitoring product
ci-app
CI product for test suite instrumentation
core
Involves Datadog core libraries
profiling
Involves Datadog profiling
labels
Apr 25, 2023
zarirhamza
removed
profiling
Involves Datadog profiling
ci-app
CI product for test suite instrumentation
appsec
Application Security monitoring product
labels
Apr 25, 2023
zarirhamza
force-pushed
the
zarir/service-name-integrations
branch
from
April 25, 2023 21:13
a693525
to
7bcf3b0
Compare
TonyCTHsu
reviewed
Apr 26, 2023
TonyCTHsu
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process to change all default values for
service_names
per integration toDD_SERVICE
service_name
values based on span attribute schema version. If version is v0, the default stays as is, otherwise if it is version v1, the default changes toDD_SERVICE
settings_spec.rb
per integration that tests the switching of defaults between v0 and v1.peer.service
values behindv0
schema version only as there will be changes to the value based on version in the future.Affected integrations:
aws
,active_record
,active_support
,dalli
,elasticsearch
,ethon
,excon
,faraday
,grpc
,http