Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default service_name values #2760

Merged
merged 19 commits into from
Apr 26, 2023
Merged

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Apr 6, 2023

Process to change all default values for service_names per integration to DD_SERVICE

  • Change default service_name values based on span attribute schema version. If version is v0, the default stays as is, otherwise if it is version v1, the default changes to DD_SERVICE
  • Adds and updates all tests for impacted integrations. This includes a new settings_spec.rb per integration that tests the switching of defaults between v0 and v1.
  • Encapsulates old peer.service values behind v0 schema version only as there will be changes to the value based on version in the future.

Affected integrations: aws, active_record, active_support, dalli, elasticsearch, ethon, excon, faraday, grpc, http

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Apr 6, 2023
@zarirhamza zarirhamza changed the title Change default service_name values Change default service_name values Part 1 Apr 7, 2023
@zarirhamza zarirhamza marked this pull request as ready for review April 7, 2023 17:14
@zarirhamza zarirhamza requested a review from a team April 7, 2023 17:14
@zarirhamza zarirhamza marked this pull request as draft April 7, 2023 17:55
@zarirhamza zarirhamza changed the title Change default service_name values Part 1 Change default service_name values Apr 7, 2023
@zarirhamza zarirhamza marked this pull request as ready for review April 7, 2023 18:59
@github-actions github-actions bot added appsec Application Security monitoring product ci-app CI product for test suite instrumentation core Involves Datadog core libraries profiling Involves Datadog profiling labels Apr 25, 2023
@zarirhamza zarirhamza removed the core Involves Datadog core libraries label Apr 25, 2023
@zarirhamza zarirhamza removed profiling Involves Datadog profiling ci-app CI product for test suite instrumentation appsec Application Security monitoring product labels Apr 25, 2023
@zarirhamza zarirhamza force-pushed the zarir/service-name-integrations branch from a693525 to 7bcf3b0 Compare April 25, 2023 21:13
@TonyCTHsu TonyCTHsu merged commit 88e9999 into master Apr 26, 2023
106 of 127 checks passed
@TonyCTHsu TonyCTHsu deleted the zarir/service-name-integrations branch April 26, 2023 15:17
@github-actions github-actions bot added this to the 1.11.0 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants