Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment about Datadog::Tracing::Distributed::Ext to correct modules #2840

Merged
merged 2 commits into from
May 18, 2023
Merged

Update comment about Datadog::Tracing::Distributed::Ext to correct modules #2840

merged 2 commits into from
May 18, 2023

Conversation

wholien
Copy link
Contributor

@wholien wholien commented May 11, 2023 •
edited

What does this PR do?

  • Datadog::Tracing::Distributed::Ext was removed in 0975630
  • Update comment to point to the correct locations of where these variables now live

Motivation

  • When updating ddtrace, it was unclear where these variables lived, as the comment was pointing to a non-existent file
  • Helps others when updating to the newest version of ddtrace

Additional Notes

How to test the change?

No need to test as it's a comment change

@wholien wholien marked this pull request as ready for review May 11, 2023 19:59
@wholien wholien requested a review from a team May 11, 2023 19:59
marcotc
marcotc approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @wholien!

@marcotc marcotc added docs Involves documentation and removed tracing labels May 16, 2023
@github-actions github-actions bot added tracing and removed docs Involves documentation labels May 18, 2023
@ivoanjo ivoanjo force-pushed the update-deprecated-comment branch from f0901f4 to 86848bf Compare May 18, 2023 15:15
@ivoanjo
Copy link
Member

ivoanjo commented May 18, 2023

+1 thanks for this, merging away! :)

@ivoanjo ivoanjo merged commit 34a743f into DataDog:master May 18, 2023
40 checks passed
@github-actions github-actions bot added this to the 1.12.0 milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
tracing
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wholien @ivoanjo @marcotc