[PROF-7654] Bump libdatadog dependency to version 3 #2948
Merged
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR bumps the libdatadog dependency on dd-trace-rb to version 3 (specifically, '~> 3.0.0.1.0'). It also includes small changes to code/tests to adapt to changes in libdatadog and get a green CI. **Motivation**: Libdatadog 3 includes the new "internal metadata" feature which we'll use in #2927. **Additional Notes**: Despite the jump in major version, the changes between libdatadog 2 and 3 were minimal. The version was bumped because the library is following semantic versioning, and a public API was changed. **How to test the change?**: Running the profiling specs exercises libdatadog, and thus we have quite a lot of test coverage for it.
marcotc
approved these changes
Jul 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR bumps the libdatadog dependency on dd-trace-rb to version 3 (specifically, '~> 3.0.0.1.0').
It also includes small changes to code/tests to adapt to changes in libdatadog and get a green CI.
Motivation:
Libdatadog 3 includes the new "internal metadata" feature which we'll use in #2927.
Additional Notes:
Despite the jump in major version, the changes between libdatadog 2 and 3 were minimal. The version was bumped because the library is following semantic versioning, and a public API was changed.
How to test the change?:
Running the profiling specs exercises libdatadog, and thus we have quite a lot of test coverage for it.