RC:Add apply state and apply error #2973
Merged
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
==========================================
- Coverage 98.09% 98.08% -0.01%
==========================================
Files 1301 1301
Lines 72574 72601 +27
Branches 3365 3365
==========================================
+ Hits 71189 71212 +23
- Misses 1385 1389 +4
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ivoanjo
reviewed
Jul 21, 2023
Comment on lines
+56
to
+62
| UNACKNOWLEDGED = 1 | ||
|
|
||
| # Set when the configuration has been successfully applied. | ||
| ACKNOWLEDGED = 2 | ||
|
|
||
| # Set when the configuration has been unsuccessfully applied. | ||
| ERROR = 3 |
There was a problem hiding this comment.
Minor: I'm curious, do we need these integers in the protocol? Could they be symbols (:error, :unacknowledged, ...) instead?
There was a problem hiding this comment.
They are numbers, as part of the protocol. Backend expects these specific values.
TonyCTHsu
reviewed
Jul 21, 2023
TonyCTHsu
approved these changes
Jul 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
apply_stateandapply_errorfields to the configuration content payload we sent back to the agent.This allows downstream systems to know if the configuration was correctly applied, and if not, why.
This is used to display to users that Remote Configuration was correctly applied, or if it was not, what was the reason.