Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash log_tags warning #3022

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Fix hash log_tags warning #3022

merged 4 commits into from
Aug 9, 2023

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Skip warning for log injection configuration when Semantic Logger's named tags override Rails built-in config.log_tags with a hash value

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Aug 2, 2023
@TonyCTHsu TonyCTHsu added this to the 1.13.1 milestone Aug 2, 2023
@TonyCTHsu TonyCTHsu marked this pull request as ready for review August 2, 2023 13:18
@TonyCTHsu TonyCTHsu requested a review from a team August 2, 2023 13:18
@codecov-commenter
Copy link

Codecov Report

Merging #3022 (bec63ef) into master (6031043) will increase coverage by 0.03%.
Report is 11 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3022      +/-   ##
==========================================
+ Coverage   98.08%   98.12%   +0.03%     
==========================================
  Files        1317     1322       +5     
  Lines       74362    74622     +260     
  Branches     3402     3403       +1     
==========================================
+ Hits        72941    73222     +281     
+ Misses       1421     1400      -21     
Files Changed Coverage Δ
lib/datadog/tracing/contrib.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/rails/log_injection.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/rails/patcher.rb 100.00% <100.00%> (ø)
...atadog/tracing/contrib/rails/log_injection_spec.rb 100.00% <100.00%> (ø)
.../datadog/tracing/contrib/suite/integration_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib_spec.rb 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu merged commit b1bec43 into master Aug 9, 2023
199 of 202 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/hash-log-tags-fix branch August 9, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning printed when using rails_semantic_logger's hash-based log_tags
3 participants