Tracing: Exclude query string for http.url tag from net/http instrumentation
#3045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
reviewed
Aug 10, 2023
marcotc
reviewed
Aug 10, 2023
delner
approved these changes
Aug 10, 2023
| span.set_tag(Tracing::Metadata::Ext::HTTP::TAG_URL, request.path) | ||
| span.set_tag( | ||
| Tracing::Metadata::Ext::HTTP::TAG_URL, | ||
| Contrib::Utils::Quantization::HTTP.url(request.path, { query: { exclude: :all } }) |
There was a problem hiding this comment.
This seems fine as a default, and you've added tests to make sure there aren't any query strings in other integrations.
Is it worth putting this same quantization line in those integrations as well? For consistency? Or is there a drawback?
There was a problem hiding this comment.
Currently, our http client integrations do not offer settings for quantization, each of them leverage their public interface to provide data.
I believe we should refactor and centralize the quantization mechanism when we offer the feature.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exclude query string for
http.urltag fromnet/httpinstrumentation