Fix ActiveRecord adapter name for Rails 7 #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
changed the title
TonyCTHsu
force-pushed
the
tonycthsu/activerecord-util-db-adapter
branch
from
1de2f86
to
3d8f8a2
Compare
anmarchenko
reviewed
Aug 16, 2023
anmarchenko
reviewed
Aug 16, 2023
marcotc
reviewed
Aug 16, 2023
TonyCTHsu
force-pushed
the
tonycthsu/activerecord-util-db-adapter
branch
from
b2911b7
to
1f86fc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3051 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 1324 1324
Lines 74830 74847 +17
Branches 3404 3406 +2
=======================================
+ Hits 73425 73444 +19
+ Misses 1405 1403 -2
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ekump
approved these changes
Aug 21, 2023
| @@ -587,6 +587,15 @@ elsif ruby_version?('2.3') | |||
| appraise 'core-old' do | |||
| gem 'dogstatsd-ruby', '~> 4' | |||
| end | |||
|
|
|||
| # Somehow, I failed to install this appraisal group with Ruby 2.4 | |||
There was a problem hiding this comment.
Should this comment be here?
There was a problem hiding this comment.
I supposed we are going to deprecate old ruby and Rails 3.x in the future, so did not invest too much solving this, so I left a comment instead.
marcotc
reviewed
Aug 21, 2023
spec/datadog/tracing/contrib/active_record/configuration/resolver_spec.rb
Outdated
Show resolved
Hide resolved
marcotc
approved these changes
Aug 21, 2023
marcotc
changed the title
…ver_spec.rb Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
anmarchenko
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2924
What does this PR do?
Fix
Utils.adapter_namefor version > 7respond_to? :db_config, instead of Rails version checkUtils.adapter_namefor settings spec to avoid flaky specRemove::ActiveRecord::ConnectionAdapters::ConnectionSpecification::Resolverfor connection resolver