include peer service configurations in telemetry payload #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
reviewed
Aug 17, 2023
| } | ||
| peer_service_mapping_str = '' |
There was a problem hiding this comment.
Do you need this value to be an empty string, instead of nil?
I ask because nil will remove it from the Hash, reducing the payload size needed to be flushed.
There was a problem hiding this comment.
Also, it would make it slightly simpler to write this, given we don't have to initialize peer_service_mapping_str anymore if we are ok with nil.
There was a problem hiding this comment.
Other tracers include the empty string since it makes it easier to recognize if the configuration is actually supported
marcotc
reviewed
Aug 17, 2023
marcotc
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new peer service configurations to telemetry data