[APPSEC-9341] Upgrade libddwaf-rb version to 1.11.0 #3087
Merged
+28
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
GustavoCaso
force-pushed
the
update-libddwaf-rb-to-1.11.0
branch
from
fe4114d
to
33922f1
Compare
GustavoCaso
changed the title
ivoanjo
changed the title
ekump
approved these changes
Aug 29, 2023
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade libddwaf to
1.11.0The latest version of libddwaf had some breaking changes on the API
Datadog::AppSec::WAF::Handle#ruleset_info->Datadog::AppSec::WAF::Handle#diagnosticsDatadog::AppSec::WAF::Result#data->Datadog::AppSec::WAF::Result#eventsMotivation:
We need to use the latest version of libddwaf to enable some features for configuring the blocking response
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!