Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix host injection error handling #3240

Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 6, 2023

What does this PR do?

Variable failure_prefix is obsolete and causing error when handling exception.
Remove an obsolete variable from host inject script .

@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 6, 2023 15:53
@TonyCTHsu TonyCTHsu self-assigned this Nov 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3240 (290d552) into master (242d338) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files        1253     1253           
  Lines       72303    72303           
  Branches     3355     3355           
=======================================
  Hits        71020    71020           
  Misses       1283     1283           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@TonyCTHsu TonyCTHsu merged commit 8ef4139 into master Nov 7, 2023
219 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-missing-variable-for-host-injection branch November 7, 2023 10:33
@github-actions github-actions bot added this to the 1.17.0 milestone Nov 7, 2023
@TonyCTHsu TonyCTHsu modified the milestones: 1.17.0, 1.16.1 Nov 7, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants