Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed:Default trace propagation styles to Datadog,tracecontext #3248

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 7, 2023

For the release notes

This release changes the default trace propagation style from Datadog,b3multi,b3 to Datadog,tracecontext.
This aligns the Ruby APM with other APM languages, increasing cross-language compatibility out of the box.

This change also improve interoperability with the W3C tracecontext propagation standard, used by OpenTelemetry systems.

Unless you are using B3 propagation and are not configuring an explicit DD_TRACE_PROPAGATION_STYLE_EXTRACT (or tracing.distributed_tracing.propagation_extract_style), this change will not reduce observability.
Otherwise, if you use B3 propagation, you can set the environment variable DD_TRACE_PROPAGATION_STYLE_EXTRACT=Datadog,b3multi,b3 to restore the previous behavior.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@marcotc marcotc requested review from a team as code owners November 7, 2023 22:11
@marcotc marcotc requested a review from a team as a code owner November 9, 2023 22:17
@marcotc marcotc requested a review from ekump November 9, 2023 22:29
@codecov-commenter
Copy link

Codecov Report

Merging #3248 (5bdf792) into master (8ef4139) will increase coverage by 0.00%.
Report is 51 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3248   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files        1253     1253           
  Lines       72303    72252   -51     
  Branches     3355     3355           
=======================================
- Hits        71019    70969   -50     
+ Misses       1284     1283    -1     
Files Coverage Δ
lib/datadog/tracing/configuration/settings.rb 95.07% <100.00%> (ø)
spec/datadog/opentelemetry_spec.rb 100.00% <100.00%> (ø)
spec/datadog/opentracer/rack_propagator_spec.rb 100.00% <100.00%> (ø)
...pec/datadog/tracing/configuration/settings_spec.rb 100.00% <100.00%> (ø)
...ec/datadog/tracing/distributed/propagation_spec.rb 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@marcotc marcotc merged commit 8fe9497 into master Nov 10, 2023
219 checks passed
@marcotc marcotc deleted the default-propgator-change branch November 10, 2023 20:08
@github-actions github-actions bot added this to the 1.17.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants