on_error settings for grape
#3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3370 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 1250 1250
Lines 72377 72377
Branches 3394 3394
=======================================
Hits 71009 71009
Misses 1368 1368 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/grape-on-error-2.0
branch
from
05c0554
to
2e17696
Compare
marcotc
approved these changes
Jan 8, 2024
brett0000FF
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Small style nits changing to present tense, avoiding temporal words, and fixing spacing before parenthetical. 👍
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
Co-authored-by: Brett Blue <84536271+brett0000FF@users.noreply.github.com>
TonyCTHsu
force-pushed
the
tonycthsu/grape-on-error-2.0
branch
from
8f1c670
to
af2af87
Compare
2 tasks
This was referenced Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
🚨 Breaking change for Grape instrumentation:
Replace
error_statuseswitherror_status_codes. Change your configuration from string to array of ranges or integers.For example:
Before:
After:
What does this PR do?
on_errorsettings forgrapeinstrumentationerror_statuseswitherror_status_codessettings forgrapeinstrumentation