Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Add b3 for default extraction #3267

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Add back b3 extraction which was removed from #3248

Motivation:

This would prevent breaking changes for user application while upgrading.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@TonyCTHsu TonyCTHsu self-assigned this Nov 20, 2023
@TonyCTHsu TonyCTHsu added this to the 1.17.0 milestone Nov 20, 2023
@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 20, 2023 20:48
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner November 20, 2023 20:48
@TonyCTHsu TonyCTHsu merged commit 8e470dc into master Nov 21, 2023
219 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/add-b3-propagation-extract branch November 21, 2023 10:06
@marcotc
Copy link
Member

marcotc commented Nov 27, 2023

I think we forgot to update the documentation:

| `tracing.distributed_tracing.propagation_extract_style` | `DD_TRACE_PROPAGATION_STYLE_EXTRACT` | `['Datadog','tracecontext']` | Distributed tracing propagation formats to extract. Overrides `DD_TRACE_PROPAGATION_STYLE`. See [Distributed Tracing](#distributed-tracing) for more details. |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants