Remove deprecated DD_PROPAGATION_STYLE env vars #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
changed the title
marcotc
force-pushed
the
remove-old-style-envs
branch
from
38cf977
to
cdbda34
Compare
marcotc
force-pushed
the
remove-old-b3
branch
from
cca755f
to
ed7d516
Compare
marcotc
force-pushed
the
remove-old-style-envs
branch
from
cdbda34
to
9ef2354
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## remove-old-b3 #3298 +/- ##
=================================================
- Coverage 97.99% 97.99% -0.01%
=================================================
Files 1248 1248
Lines 72031 72011 -20
Branches 3392 3392
=================================================
- Hits 70590 70570 -20
Misses 1441 1441 ☔ View full report in Codecov by Sentry. |
anmarchenko
approved these changes
Dec 1, 2023
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
The deprecated environment variable
DD_PROPAGATION_STYLE_INJECThas been replaced byDD_TRACE_PROPAGATION_STYLE_INJECT.The deprecated environment variable
DD_PROPAGATION_STYLE_EXTRACThas been replaced byDD_TRACE_PROPAGATION_STYLE_EXTRACT.Motivation:
The new variables have been available for a very long, and align with the rest of Datadog tracers.
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!