Remove support for Rails 3 #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
appsec
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3324 +/- ##
==========================================
+ Coverage 97.99% 98.06% +0.06%
==========================================
Files 1246 1243 -3
Lines 71960 71873 -87
Branches 3401 3388 -13
==========================================
- Hits 70520 70481 -39
+ Misses 1440 1392 -48 ☔ View full report in Codecov by Sentry. |
marcotc
force-pushed
the
remove-rails3
branch
from
45a4c61
to
2c6e2f9
Compare
ekump
reviewed
Dec 12, 2023
| @@ -1,6 +1,5 @@ | |||
| Component,Origin,License,Copyright | |||
| lib/datadog/core/vendor/multipart-post,https://github.com/socketry/multipart-post,MIT,"Copyright (c) 2007-2013 Nick Sieger." | |||
| lib/datadog/tracing/contrib/active_record/vendor,https://github.com/rails/rails/,MIT,"Copyright (c) 2005-2018 David Heinemeier Hansson" | |||
There was a problem hiding this comment.
was this an automated process, or did you know you had to manually remove this license?
There was a problem hiding this comment.
I just kind of remembered it, I think it was luck.
Not sure if it's worth creating a GH Action for such detection.
ekump
approved these changes
Dec 12, 2023
marcotc
force-pushed
the
remove-rails3
branch
from
2c6e2f9
to
4684459
Compare
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
Support for Rails 3 has been removed.
Motivation:
Rails 3's last release is from 2016. It support requires custom code relative to newer versions of Rails.
Additional Notes:
How to test the change?
There are integration tests covering the Rails integration.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!