Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove span operation aliases #3330

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Dec 14, 2023

2.0 Upgrade Guide notes

  1. Remove deprecated options span_type on trace method
  2. Remove deprecated methods from SpanOperation and Span

If you are accessing SpanOperation with manual instrumentation or pipeline processors

  • Change span_op.span_id to span_op.id
  • Change span_op.span_type to span_op.type
  • Change span_op.span_type = to span_op.type =

For example:

Change

Datadog::Tracing.trace('my_span', span_type: 'custom') do |span_op|
  span_op.span_type = "...."
end

To

Datadog::Tracing.trace('my_span', type: 'custom') do |span_op|
  span_op.type = "...."
end

Additional notes

Temporary disable graphql test, because the instrumentation lives in https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/tracing/data_dog_tracing.rb

@github-actions github-actions bot added tracing integrations Involves tracing integrations labels Dec 14, 2023
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/remove-spand-id-alias branch from 76c6b6e to 92384fa Compare December 14, 2023 17:25
@TonyCTHsu TonyCTHsu marked this pull request as ready for review December 15, 2023 17:04
@TonyCTHsu TonyCTHsu requested review from a team as code owners December 15, 2023 17:04
@TonyCTHsu TonyCTHsu self-assigned this Dec 20, 2023
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner January 9, 2024 14:35
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/remove-spand-id-alias branch from c52cc94 to aa41c89 Compare January 9, 2024 19:50
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/remove-spand-id-alias branch from aa41c89 to d43ff3b Compare January 9, 2024 20:04
@codecov-commenter
Copy link

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (6ea3035) 98.10% compared to head (d43ff3b) 98.08%.

Files Patch % Lines
spec/datadog/tracing/contrib/rails/rack_spec.rb 84.21% 3 Missing ⚠️
...ontrib/sidekiq/server_internal_tracer/heartbeat.rb 0.00% 2 Missing ⚠️
...sidekiq/server_internal_tracer/scheduled_poller.rb 0.00% 2 Missing ⚠️
...b/sidekiq/server_internal_tracer/heartbeat_spec.rb 0.00% 2 Missing ⚠️
...iq/server_internal_tracer/scheduled_poller_spec.rb 0.00% 2 Missing ⚠️
...ontrib/sidekiq/server_internal_tracer/job_fetch.rb 0.00% 1 Missing ⚠️
...ntrib/sidekiq/server_internal_tracer/redis_info.rb 0.00% 1 Missing ⚠️
...ing/contrib/sidekiq/server_internal_tracer/stop.rb 0.00% 1 Missing ⚠️
...g/contrib/active_model_serializers/patcher_spec.rb 66.66% 1 Missing ⚠️
...atadog/tracing/contrib/aws/instrumentation_spec.rb 95.23% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3330      +/-   ##
==========================================
- Coverage   98.10%   98.08%   -0.03%     
==========================================
  Files        1250     1250              
  Lines       72377    72360      -17     
  Branches     3394     3394              
==========================================
- Hits        71009    70974      -35     
- Misses       1368     1386      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit dd655fb into 2.0 Jan 9, 2024
151 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-spand-id-alias branch January 9, 2024 20:21
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu removed this from the 2.0 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants