Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ddtrace transport constants #3336

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Remove ddtrace transport constants #3336

merged 1 commit into from
Jan 5, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 15, 2023

2.0 Upgrade Guide notes
The module Datadog::Transport::Ext::HTTP has been removed, use Datadog::Core::Transport::Ext::HTTP instead.
The module Datadog::Transport::Ext::Test has been removed, use Datadog::Core::Transport::Ext::Test instead.
The module Datadog::Transport::Ext::UnixSocket has been removed, use Datadog::Core::Transport::Ext::UnixSocket instead.

Motivation:
This module has been moved, but the an old "alias" for it was left behind for backwards compatibility.

How to test the change?
All tests should pass after removing this unused code.

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc requested a review from a team as a code owner December 15, 2023 20:39
@marcotc marcotc self-assigned this Dec 15, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dbbdb9) 98.06% compared to head (03b73be) 98.06%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3336      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files        1241     1241              
  Lines       71830    71830              
  Branches     3386     3386              
==========================================
- Hits        70438    70437       -1     
- Misses       1392     1393       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit dd43673 into 2.0 Jan 5, 2024
152 checks passed
@marcotc marcotc deleted the remove-ddtrace-dir branch January 5, 2024 20:07
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants