[NO-TICKET] Use Ruby 3.3 stable for CI testing #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?** This PR updates our dockerfiles so that the Ruby 3.3 stable release (currently 3.3.0) gets used for CI testing, replacing the RC releases. **Motivation:** Make sure dd-trace-rb is working correctly on 3.3 . **Additional Notes:** The docker image under `.circleci` doesn't get automatically picked up by CI. I'll make sure to manually run the "Build Ruby" workflow (https://github.com/DataDog/dd-trace-rb/actions/workflows/build-ruby.yml) with the "Push images" option after this PR gets merged. **How to test the change?** Validate that the following CI steps still pass: * Ruby 3.3 integration (will pick up the new Ruby) * Build Ruby (will be able to build the new Ruby)
2 tasks
TonyCTHsu
approved these changes
Jan 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
- Coverage 98.23% 98.23% -0.01%
==========================================
Files 1253 1253
Lines 73035 73035
Branches 3429 3428 -1
==========================================
- Hits 71749 71747 -2
- Misses 1286 1288 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates our dockerfiles so that the Ruby 3.3 stable release (currently 3.3.0) gets used for CI testing, replacing the RC releases.
Motivation:
Make sure dd-trace-rb is working correctly on 3.3 .
Additional Notes:
The docker image under
.circlecidoesn't get automatically picked up by CI.I'll make sure to manually run the "Build Ruby" workflow (https://github.com/DataDog/dd-trace-rb/actions/workflows/build-ruby.yml) with the "Push images" option after this PR gets merged.
How to test the change?
Validate that the following CI steps still pass:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.