Pass the service name to instantiation spans #3383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment put at the time where not reflecting setup of a specific service_name. DataDog@f64a90c#diff-480dabeac4cb83aeebfd219880fbbaafff3c0b3a83cef7b2fa0e3819e3b516a5R60-R61
benoittgt
force-pushed
the
service-name-on-instantiation
branch
from
2c2cdb8
to
e5f064a
Compare
benoittgt
commented
Jan 16, 2024
| @@ -110,7 +109,7 @@ | |||
|
|
|||
| expect(instantiation_span.name).to eq('active_record.instantiation') | |||
| expect(instantiation_span.span_type).to eq('custom') | |||
| expect(instantiation_span.service).to eq(tracer.default_service) # Because within parent | |||
There was a problem hiding this comment.
I think we could test also the fallback when
service_name: database_service
is not defined.
|
I left a comment on the original issue. |
|
Thanks @TonyCTHsu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix #3359
This is a draft because I think we need to have a discussion first on the issue.
Motivation:
Having the same service name for "instantiation spans" and "sql spans".
Additional Notes:
I don't know how this change can impact end user.
How to test the change?
It has been tested in spec suite but should be tested E2E. 馃槃
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!