Improve performance of gathering the ClassCount metric #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJF
approved these changes
Jan 18, 2024
ekump
approved these changes
Jan 18, 2024
ivoanjo
force-pushed
the
ivoanjo/optimize-class-count
branch
from
73a844c
to
11b79f3
Compare
|
Update: Rebased on top of current master to pull in #3387 and get a green CI again. |
|
CI is broken... Unrelated to this PR... Again... Fix is in #3390, I'll rebase once it's in master... |
ivoanjo
force-pushed
the
ivoanjo/optimize-class-count
branch
from
31dddb9
to
37eec47
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
=======================================
Coverage 98.25% 98.25%
=======================================
Files 1262 1262
Lines 73603 73603
Branches 3442 3443 +1
=======================================
Hits 72316 72316
Misses 1287 1287 ☔ View full report in Codecov by Sentry. |
**What does this PR do?** This PR tweaks the `ClassCount.available?` method to cache its result. The result is expected to be always the same for a given Ruby VM, so we don't need to keep checking again and again. **Motivation:** While looking at our GitLab test deployments, I noticed that on this big app, calling `ObjectSpace.count_objects` does have some cost (because this method goes through the whole Ruby heap). I then noticed we _always_ call it twice in a row -- we call `available?` and then call `value`:  It's trivial to avoid this, so I decided to open this tiny PR. **Additional Notes:** N/A **How to test the change?** Existing test coverage is enough :)
ivoanjo
force-pushed
the
ivoanjo/optimize-class-count
branch
from
9da8507
to
eb504fc
Compare
|
So it appears that we were missing a few gemfile updates, that our github action pushed into this PR. I've looked into them and they look good. Going ahead and merging this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tweaks the
ClassCount.available?method to cache its result.The result is expected to be always the same for a given Ruby VM, so we don't need to keep checking again and again.
Motivation:
While looking at our GitLab test deployments, I noticed that on this big app, calling
ObjectSpace.count_objectsdoes have some cost (because this method goes through the whole Ruby heap).I then noticed we always call it twice in a row -- we call
available?and then callvalue:It's trivial to avoid this, so I decided to open this tiny PR.
Additional Notes:
N/A
How to test the change?
Existing test coverage is enough :)
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.