Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frozen string literals #3392

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Frozen string literals #3392

merged 5 commits into from
Feb 1, 2024

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Jan 22, 2024

2.0 Upgrade Guide notes

🚨 In 2.0, all the strings are frozen. Make sure your code does not mutate them.

@TonyCTHsu TonyCTHsu changed the base branch from master to 2.0 January 22, 2024 15:38
@github-actions github-actions bot added appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations profiling Involves Datadog profiling tracing labels Jan 22, 2024
@TonyCTHsu TonyCTHsu marked this pull request as ready for review January 23, 2024 10:13
@TonyCTHsu TonyCTHsu requested review from a team as code owners January 23, 2024 10:13
@TonyCTHsu TonyCTHsu self-assigned this Jan 24, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5cb48c5) 98.13% compared to head (4458dde) 98.13%.
Report is 26 commits behind head on 2.0.

Files Patch % Lines
lib/datadog/tracing/span_operation.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.0    #3392   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files        1249     1249           
  Lines       72086    72079    -7     
  Branches     3372     3372           
=======================================
- Hits        70741    70736    -5     
+ Misses       1345     1343    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu merged commit 5877ab3 into 2.0 Feb 1, 2024
153 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/frozen-strings branch February 1, 2024 19:52
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations profiling Involves Datadog profiling tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants