Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sinatra :Remove deprecated constants #3401

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Sinatra :Remove deprecated constants #3401

merged 1 commit into from
Jan 25, 2024

Conversation

TonyCTHsu
Copy link
Contributor

2.0 Upgrade Guide notes

🚨 Remove following constants

Datadog::Tracing::Contrib::Sinatra::Ext::RACK_ENV_REQUEST_SPAN
Datadog::Tracing::Contrib::Sinatra::Ext::RACK_ENV_MIDDLEWARE_START_TIME
Datadog::Tracing::Contrib::Sinatra::Ext::RACK_ENV_MIDDLEWARE_TRACED

@TonyCTHsu TonyCTHsu requested review from a team as code owners January 25, 2024 17:09
@TonyCTHsu TonyCTHsu changed the base branch from master to 2.0 January 25, 2024 17:09
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52aded8) 98.12% compared to head (a21e1f1) 98.12%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              2.0    #3401      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files        1243     1243              
  Lines       72026    72023       -3     
  Branches     3376     3376              
==========================================
- Hits        70674    70670       -4     
- Misses       1352     1353       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brett0000FF
brett0000FF reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing for Docs.

@TonyCTHsu TonyCTHsu merged commit b9c8ffb into 2.0 Jan 25, 2024
151 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/remove-deprecated-sinatra-constant branch January 25, 2024 19:33
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@ivoanjo ivoanjo added the 2.0 label Mar 14, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
This was referenced Apr 12, 2024
Closed
Closed
Merged
Merged
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brett0000FF brett0000FF brett0000FF left review comments

@marcotc marcotc marcotc approved these changes

@ekump ekump ekump approved these changes

Assignees
No one assigned
Labels
2.0 integrations Involves tracing integrations tracing
Projects
None yet
Milestone
2.0.0.beta1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TonyCTHsu @codecov-commenter @marcotc @ekump @brett0000FF @ivoanjo