Sidekiq : Remove worker specific configuration
#3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
commented
Jan 25, 2024
| @@ -75,8 +75,6 @@ def perform | |||
|
|
|||
| context 'with custom job' do | |||
| before do | |||
| allow(Datadog.configuration.tracing).to receive(:[]).with(:sidekiq).and_return(sidekiq_options) | |||
There was a problem hiding this comment.
This is just bad practice for test. I refactored a bit code to inject options for middleware
ekump
approved these changes
Jan 25, 2024
marcotc
approved these changes
Jan 25, 2024
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
馃毃 Remove Sidekiq worker specific configuration
Defining
datadog_tracer_configon Sidekiq worker is never documented and publicly supported. Hence removing the code.