do not restrict startup logs to emit only once #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekump
force-pushed
the
ekump/startup-logs-can-run-emit-more-than-once
branch
from
f9a090e
to
13a2c2f
Compare
ekump
force-pushed
the
ekump/startup-logs-can-run-emit-more-than-once
branch
from
13a2c2f
to
055ed8f
Compare
ekump
force-pushed
the
ekump/startup-logs-can-run-emit-more-than-once
branch
from
055ed8f
to
d56d820
Compare
ivoanjo
approved these changes
Feb 7, 2024
Comment on lines
40
to
47
| context 'with multiple invocations' do | ||
| it 'executes only once' do | ||
| it 'executes multiple times' do | ||
| env_logger.collect_and_log! | ||
| env_logger.collect_and_log! | ||
|
|
||
| expect(logger).to have_received(:info).once | ||
| expect(logger).to have_received(:info).twice | ||
| end | ||
| end |
There was a problem hiding this comment.
Minor: Since this behavior was inherited from the parent module, I think we could probably simplify the spec and remove this test case instead?
There was a problem hiding this comment.
Sure. I debated just removing these tests myself, but left them in to see if anyone else thought they were superfluous.
TonyCTHsu
approved these changes
Feb 7, 2024
ekump
force-pushed
the
ekump/startup-logs-can-run-emit-more-than-once
branch
from
54c29e8
to
ee9e83e
Compare
2 tasks
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0 Upgrade Guide notes
In 1.x startup logs would emit only once during initial configuration of the library. In 2.0 these logs will now emit whenever the library reconfigures itself, which may occur multiple times during startup. The increased verbosity in logging better represents the configuration state of the library at the time the logs are generated.
The default setting has not changed for startup logs. It remains
nil, which generates startup logs for non-dev environments. To turn off startup logs completely you can set:What does this PR do?
Remove the
log_oncerestriction on startup logs.Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!