Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated lazy method for option_definition #3454

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

ekump
Copy link
Contributor

@ekump ekump commented Feb 11, 2024

2.0 Upgrade Guide notes
Configuration options can no longer be defined as lazy. All options are lazily evaluated, making this redundant.

What does this PR do?
Removes a deprecated method on option_definition for defining a configuration option as lazy.

Motivation:

Additional Notes:

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the core Involves Datadog core libraries label Feb 11, 2024
@ekump ekump marked this pull request as ready for review February 11, 2024 20:23
@ekump ekump requested a review from a team as a code owner February 11, 2024 20:23
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cb48c5) 98.13% compared to head (48eeed1) 98.10%.
Report is 107 commits behind head on 2.0.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0    #3454      +/-   ##
==========================================
- Coverage   98.13%   98.10%   -0.03%     
==========================================
  Files        1249     1261      +12     
  Lines       72086    72985     +899     
  Branches     3372     3419      +47     
==========================================
+ Hits        70741    71605     +864     
- Misses       1345     1380      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ekump ekump merged commit 9d4dbbb into 2.0 Feb 13, 2024
153 checks passed
@ekump ekump deleted the ekump/remove-lazy-config-option-method branch February 13, 2024 15:35
@TonyCTHsu TonyCTHsu added the 2.0 label Feb 20, 2024
@TonyCTHsu TonyCTHsu added this to the 2.0 milestone Feb 20, 2024
@TonyCTHsu TonyCTHsu modified the milestones: 2.0, 2.0.0.beta1 Mar 22, 2024
@marcotc marcotc mentioned this pull request Apr 2, 2024
2 tasks
@TonyCTHsu TonyCTHsu mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 core Involves Datadog core libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants