Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

rack.request span that are stopped in middleware or before action doesn't have resource set #3482

Open
beauraF opened this issue Feb 25, 2024 · 0 comments
Labels
bug Involves a bug community Was opened by a community member

Comments

@beauraF
Copy link

beauraF commented Feb 25, 2024

Hello everyone 馃憢

I'm opening a dedicated bug report following this discussion.

This has a significant impact on the monitoring and alerting systems implemented by our teams. Since these spans have no resources, it is not possible to infer a team from them. This broke the reporting of dashboard built by team, and also our custom code that set a service to a rack.request based on the resource.

I've already seen several teams remove before_action, by calling directly into the controller's action to workaround this behavior ; after often spending several hours before understanding this subtlety.

@delner you made a proposal in the initial discussion, is that's still the direction you want to go in?


Current behaviour
rack.request span that are stopped in middleware or before action doesn't have resource set

Expected behaviour
rack.request span that are stopped in before action have resource set. Middleware also?

Environment

  • ddtrace version: 1.20.0
  • Ruby version: 3.2.3
@beauraF beauraF added bug Involves a bug community Was opened by a community member labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Development

No branches or pull requests

1 participant