Add bin/ddprofrb #3501
Merged
Add bin/ddprofrb #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
force-pushed
the
feature/add_ddprofrb_bin
branch
from
f8ebcdc
to
fc77122
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3501 +/- ##
==========================================
- Coverage 98.24% 98.23% -0.01%
==========================================
Files 1275 1275
Lines 75182 75182
Branches 3551 3551
==========================================
- Hits 73859 73858 -1
- Misses 1323 1324 +1 ☔ View full report in Codecov by Sentry. |
ivoanjo
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Looks reasonable! Only thing missing is ddtracerb not working due to the require_relative.
Also note to self: I'll need to update https://docs.datadoghq.com/profiler/enabling/ruby/?tab=environmentvariables#installation once this is merged.
delner
force-pushed
the
feature/add_ddprofrb_bin
branch
from
fc77122
to
9741fee
Compare
ivoanjo
added a commit
to DataDog/documentation
that referenced
this pull request
Mar 4, 2024
**What does this PR do?** This PR updates the "Enabling the Ruby profiler" page to use the `ddprofrb` command as a replacement for the `ddtracerb` command that was deprecated in DataDog/dd-trace-rb#3501 . The old command is still going to be kept around for a while longer, and emits a deprecation warning when used. **Motivation:** Make sure customers onboard using the recommended instructions.
Merged
1 task
|
Docs update PR: DataDog/documentation#22037 |
brett0000FF
pushed a commit
to DataDog/documentation
that referenced
this pull request
Mar 19, 2024
…#22037) * Update "Enabling the Ruby profiler" to use the new `ddprofrb` command **What does this PR do?** This PR updates the "Enabling the Ruby profiler" page to use the `ddprofrb` command as a replacement for the `ddtracerb` command that was deprecated in DataDog/dd-trace-rb#3501 . The old command is still going to be kept around for a while longer, and emits a deprecation warning when used. **Motivation:** Make sure customers onboard using the recommended instructions. * Apply suggestions from code review Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com> --------- Co-authored-by: cecilia saixue watt <cecilia.watt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the
bin/ddprofrbscript, which is identical to thebin/ddtracerbscript, which it intends to replace. It also prints a deprecation warning for any use ofbin/ddtracerb.Motivation:
The naming did not reflect the actual function of the bin. This better aligns it to its purpose.
Additional Notes:
We will remove
bin/ddtracerbin the 2.0 release.