Rename Profiling files to reflect "datadog" instead of "ddtrace" #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
dev/refactor
delner
added
the
dev/internal
delner
force-pushed
the
refactor/rename_profiling_files_to_datadog
branch
3 times, most recently
from
9abd38b
to
0a4157d
Compare
delner
force-pushed
the
refactor/rename_profiling_files_to_datadog
branch
from
0a4157d
to
cee639d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3502 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 1275 1275
Lines 75182 75182
Branches 3551 3551
=======================================
Hits 73858 73858
Misses 1324 1324 ☔ View full report in Codecov by Sentry. |
delner
force-pushed
the
refactor/rename_profiling_files_to_datadog
branch
from
cee639d
to
ca64085
Compare
delner
force-pushed
the
refactor/rename_profiling_files_to_datadog
branch
from
ca64085
to
6a5dda4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the names/filepaths of the profiling code to reflect "datadog" instead of "ddtrace". Should not functionally change anything, or contain any breaking changes.
Motivation:
Per @ivoanjo 's suggestion that we extract the profiling rename from a larger rename PR. This change seems isolated and internal, which should make it a good candidate for its own PR.
Additional Notes:
This is an early step towards a larger rename to
datadogin 2.0. There may be more changes to the C code (constant names) or other references toddtrace. Those changes will happen in another PR.