chore(tracing): Adds trace_remote field to TraceDigest #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3516 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 1237 1237
Lines 72254 72276 +22
Branches 3408 3408
=======================================
+ Hits 70863 70886 +23
+ Misses 1391 1390 -1 ☔ View full report in Codecov by Sentry. |
mabdinur
commented
Mar 15, 2024
mabdinur
commented
Mar 15, 2024
mabdinur
force-pushed
the
munir/add-is-remote
branch
from
b308587
to
c59e423
Compare
mabdinur
changed the title
mabdinur
commented
Mar 15, 2024
marcotc
reviewed
Mar 15, 2024
| @@ -299,6 +302,7 @@ def to_digest | |||
| trace_service: service, | |||
| trace_state: @trace_state, | |||
| trace_state_unknown_fields: @trace_state_unknown_fields, | |||
| trace_remote: (@remote_parent && @active_span.nil?), | |||
There was a problem hiding this comment.
Do we need @active_span.nil? here?
There was a problem hiding this comment.
Yup. If we are creating a digest for an active span then trace_remote should be False. The digest represent a span that is local to the process.
marcotc
reviewed
Mar 15, 2024
2 tasks
marcotc
approved these changes
Mar 18, 2024
This was referenced Apr 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a mechanism to track whether a TraceDigest represents a remote span or if it is local to a host. This change is analogous to a change made in NodeJS: DataDog/dd-trace-js#4153.
is_remoteortrace_remoteis an opentelemetry concept and is defined here: https://opentelemetry.io/docs/specs/otel/trace/api/#isremote.Motivation:
This new field will be used to propagate the last datadog parent id in w3c tracecontext headers. This change blocks: #3488
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!