Fix ActiveRecord resolve function #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3523 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 1275 1275
Lines 75303 75329 +26
Branches 3558 3559 +1
=======================================
+ Hits 73977 74004 +27
+ Misses 1326 1325 -1 ☔ View full report in Codecov by Sentry. |
TonyCTHsu
force-pushed
the
tonycthsu/fix-activerecord-resolving
branch
from
4b47bd6
to
c3fe261
Compare
TonyCTHsu
commented
Mar 14, 2024
| ) | ||
|
|
||
| nil |
There was a problem hiding this comment.
It is important to return nil, otherwise, true is returned, causing exception during resolving
marcotc
approved these changes
Mar 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3522
What does this PR do?
When an invalid string is provided for multiplexing configuration, although it logs an error, it still add the matcher
trueto the configuration. Later during resolving, an exception will be raised.In this PR, the mitigation is to skip adding the matcher if the input is invalid, also reduce the log message.