[NO-TICKET] Upgrade to libdatadog 7 #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
added a commit
to DataDog/libdatadog
that referenced
this pull request
Mar 19, 2024
**What does this PR do?** This PR includes the changes documented in the "Releasing a new version to rubygems.org" part of the README: https://github.com/datadog/libdatadog/tree/main/ruby#releasing-a-new-version-to-rubygemsorg (It's also very similar to the same as the v6.0.0 release PR). **Motivation:** Enable Ruby to use libdatadog v7.0.0. **Additional Notes:** N/A **How to test the change?** I've tested this release locally against the changes in DataDog/dd-trace-rb#3536 . As a reminder, new libdatadog releases don't get automatically picked up by dd-trace-rb, so the PR that bumps the Ruby profiler will also test this release against all supported Ruby versions.
2 tasks
**What does this PR do?** This PR upgrades dd-trace-rb to use libdatadog 7. There was a small breaking API change -- the rename of `ddog_Endpoint` APIs to `ddog_prof_Endpoint`. **Motivation:** Make sure Ruby is up-to-date on libdatadog. **Additional Notes:** As far as Ruby is impacted, the main changes in libdatadog 7 are a number of fixes to the crash tracker (getting us closer to merging #3384) as well as some potential memory improvements from (DataDog/libdatadog#303). I'm opening this as a draft PR as libdatadog 7 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is. **How to test the change?** Our existing test coverage includes libdatadog testing, so a green CI is good here :)
ivoanjo
force-pushed
the
ivoanjo/libdatadog7-upgrade
branch
from
7c22c7d
to
74456b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3536 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 1274 1274
Lines 75157 75157
Branches 3539 3539
=======================================
+ Hits 73857 73858 +1
+ Misses 1300 1299 -1 ☔ View full report in Codecov by Sentry. |
AlexJF
approved these changes
Mar 27, 2024
|
I've deployed this commit to the reliability environment and no relevant indicators seem to have moved, so we're in good shape -- pressing the magic merge button. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR upgrades dd-trace-rb to use libdatadog 7.
There was a small breaking API change -- the rename of
ddog_EndpointAPIs toddog_prof_Endpoint.Motivation:
Make sure Ruby is up-to-date on libdatadog.
Additional Notes:
As far as Ruby is impacted, the main changes in libdatadog 7 are a number of fixes to the crash tracker (getting us closer to merging #3384) as well as some potential memory improvements from (DataDog/libdatadog#303).
I'm opening this as a draft PR as libdatadog 7 is not yet available on rubygems.org, and I'll come back to re-trigger CI and mark this as non-draft once it is.DoneHow to test the change?
Our existing test coverage includes libdatadog testing, so a green CI is good here :)
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.