-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequel integration #367
Sequel integration #367
Conversation
Hey @palin , thanks for putting this together! Love seeing support for new libraries. We've been particularly interested in adding Sequel for some time now, too, so this is great. I'll take a look through this when you feel it's ready for review. In the mean time, since we do require tests for contributions, I'd suggest adding some RSpec tests that exercise this new integration. |
017aa5f
to
98183c0
Compare
Hi @delner, sorry didn't see your comment before. |
@palin Sorry for catching this late, but I was looking through old PRs and found this one #171 which seems to already add Sequel integration. Does this PR do something that this one doesn't? If it does, we should maybe rebase this PR on top of that one and any missing functionality. Otherwise I think we should close this one. |
@palin I don't yet, other to say that it's on our queue, albeit unscheduled. I'll can let you know as things develop. |
OK, please let me know then. Thanks |
No description provided.