Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The sinatra tracer does not record the request id #375

Closed
jamiehodge opened this issue Mar 20, 2018 · 3 comments
Closed

The sinatra tracer does not record the request id #375

jamiehodge opened this issue Mar 20, 2018 · 3 comments
Assignees
Labels
feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Milestone

Comments

@jamiehodge
Copy link
Contributor

The rack tracer currently adds a request id tag (X-Request-Id header) to each span. It would be nice if the sinatra tracer did the same.

@delner delner added integrations Involves tracing integrations feature-request A request for a new feature or change to an existing one labels Apr 9, 2018
@delner
Copy link
Contributor

delner commented Apr 25, 2018

Hey @jamiehodge , would it be reasonable to suggest activating the Rack tracer to get the benefit of this feature (given Sinatra uses Rack)? It would create a Rack span above your current Sinatra span with these tags.

Otherwise, it should be possible to add it to Sinatra without activating Rack, but will require some work on the integration.

@delner
Copy link
Contributor

delner commented Jun 15, 2018

@jamiehodge We're planning on releasing 0.13.0 on Wednesday June 20th, which should include support for this via #427. The request ID should appear as a tag on the Sinatra span by default, but you could further configure which headers you'd like to see via the following:

Datadog.configure do |c|
  # Add these request and response headers as tags
  c.use :sinatra, headers: { request: ['Accept-Encoding'], response: ['Content-Encoding'] }
end

Will that work for you?

@delner delner self-assigned this Jun 15, 2018
@delner delner added this to the 0.13.0 milestone Jun 15, 2018
@delner
Copy link
Contributor

delner commented Jun 20, 2018

This should be addressed with our 0.13.0 release. Closing this.

@delner delner closed this as completed Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature or change to an existing one integrations Involves tracing integrations
Projects
None yet
Development

No branches or pull requests

2 participants