Fix deprecation warnings when Rack Env is re-used #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
bug
|
Still need to fix up Rubocop and add tests. |
delner
force-pushed
the
bugfix/unicorn_triggers_rack_deprecation_warnings
branch
from
529f754
to
13d8c5c
Compare
delner
force-pushed
the
bugfix/unicorn_triggers_rack_deprecation_warnings
branch
from
32f7c79
to
f51ab0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a deprecation warning for the Rack integration when the Rack Env is accessed using the symbol name that was deprecated. This warning is triggered on a edge case where the same Env object is passed through the middleware multiple times; presumably because a web server is re-using the object instead of allocating new memory. This most readily manifests when using Unicorn.
This pull request adds a block around Datadog's use of the deprecated symbol (which exists for backwards compatibility) so that it doesn't raise this error if the object is re-used.