Upgrade to integrations to new configuration API #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
force-pushed
the
refactor/upgrade_to_integration_configuration
branch
2 times, most recently
from
966f7e4
to
bb6b171
Compare
delner
force-pushed
the
refactor/upgrade_to_integration_configuration
branch
5 times, most recently
from
e7f8cca
to
e772421
Compare
* Changed: ConfigurationHelpers#remove_patch! to work with Integration patchers. * Refactored: Resque to use Datadog::Contrib::Integration.
delner
force-pushed
the
refactor/upgrade_to_integration_configuration
branch
from
e772421
to
16d9782
Compare
* Refactored: Mysql2 to use Datadog::Contrib::Integration. * Fixed: Mysql2 tests not working locally.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get consistent behavior, and access to new functions, we should upgrade all of our integrations to the new integration API added in #450 .
Upgrades should be backwards compatible, and users should not need to make any changes to their existing configurations in order to use this newly upgraded API.
Here's a list of all the integrations that need to be upgraded:
After all of these have been updated, we should merge this PR.