Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for mysql2 and databases option #578

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Oct 1, 2018

In this pull request we fix a couple of issues in the documentation:

  • mysql2 supports down to version 0.3.21, not just >= 0.5.0
  • Removed a databases option in Rails, because it doesn't actually exist. This was superseded by a different implementation, which already had a correct code sample in the documentation. See Rails databases: {} option #574 for details.

@delner delner changed the base branch from master to 0.17-dev October 1, 2018 19:40
@delner delner self-assigned this Oct 1, 2018
@delner delner requested a review from pawelchcki October 1, 2018 19:40
@delner delner added the docs Involves documentation label Oct 1, 2018
@delner delner mentioned this pull request Oct 1, 2018
@delner delner merged commit b949baf into 0.17-dev Oct 2, 2018
@delner delner deleted the docs/update_mysql2_and_databases branch October 2, 2018 15:08
@delner delner added this to the 0.17.0 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants