Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tracer environment variables if provided #631

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

delner
Copy link
Contributor

@delner delner commented Nov 12, 2018

To make the tracer easier to use within containerized implementations, the tracer will now use the following environment variables, if available.

  • DD_AGENT_HOST: Hostname of agent, e.g. localhost or 127.0.0.1. Defaults to 127.0.0.1.
  • DEFAULT_TRACE_AGENT_PORT: Port on which trace agent is listening. Defaults to 8126.

These defaults and environment variables can still be overridden via Datadog.configure { |c| c.tracer hostname: 'localhost', port: 8126 } or tracer.configure(hostname: 'localhost', port: 8126).

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Nov 12, 2018
@delner delner added this to the 0.18.0 milestone Nov 12, 2018
@delner delner self-assigned this Nov 12, 2018
@@ -1,6 +1,6 @@
DD_AGENT_HOST=localhost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit f071215 into 0.18-dev Nov 13, 2018
@delner delner deleted the feature/use_dd_env_vars branch November 13, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants