Change configuration resolution misses to return default configuration #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
Merged
pawelchcki
reviewed
Dec 10, 2018
| module_function | ||
|
|
||
| def normalize_vendor(vendor) | ||
| case vendor | ||
| when nil | ||
| 'defaultdb' | ||
| VENDOR_DEFAULT |
pawelchcki
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes a few things:
Datadog::Utils::Databasevalues to constants.nilwhen a configuration with a mismatching key is requested.defaultdb, then default instead to the adapter name.These changes were in order to get ActiveRecord to return service names more consistently. If connections were manually established after the AR integration was activated (when it could not determine a good default service name from a connection), spans could end up with bad service names (
defaultdb).By always returning at minimum the default settings object, ActiveRecord could then use those settings to determine the best name for the span based on what's available.