Deprecate Dalli pin in favor of configuration API #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
brettlangdon
approved these changes
Feb 19, 2019
delner
force-pushed
the
refactor/dalli_replace_pin_with_config
branch
from
35821ca
to
89350ab
Compare
delner
force-pushed
the
refactor/dalli_replace_pin_with_config
branch
from
89350ab
to
ddc5da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #692
Dalli still uses
Datadog::Pinto drive configuration. Users are likely usingDalli.datadog_pin.service_name = 'my_service'to set things which is something we definitely do not want to do.This pull requests changes the integration to use the configuration API, and deprecates the use of
#datadog_pinas a means to drive configuration, and now raises warnings when it is accessed this way. Instead, when the pin is accessed and configured, it will apply the appropriate configuration via the configuration API.Changes here should be backwards compatible; any users using old means should receive a warning to upgrade while still preserving existing functionality.