Deprecate GRPC global pin in favor of configuration API #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
delner
force-pushed
the
refactor/grpc_replace_pin_with_config
branch
from
24b36e7
to
fc806dd
Compare
brettlangdon
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC uses
Datadog::Pinto drive configuration, for global settings and individual interceptors.This pull requests changes the integration to use the configuration API instead of the global pin, and deprecates the use of
GRPC.datadog_pinas a means to drive configuration, and now raises warnings when it is accessed this way. Instead, when the pin is accessed and configured, it will apply the appropriate configuration via the configuration API.It will still continue to use
Datadog::Pinobjects when trace settings are configured for an individual interceptor, so this part of the API will remain the same.Changes here should be backwards compatible; any users using the global pin directly should receive a warning to upgrade while still preserving existing functionality. Users who use the pin attached to interceptors should not see a change in behavior there.