Add analytics global flag #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
force-pushed
the
feature/add_event_sample_rate_to_all_integrations
branch
2 times, most recently
from
34ae074
to
b7660eb
Compare
delner
force-pushed
the
feature/analytics_global_flag
branch
from
1898b1f
to
112fe03
Compare
|
@brettlangdon This should be fixed, and ready for another review. |
brettlangdon
approved these changes
Mar 11, 2019
delner
force-pushed
the
feature/analytics_global_flag
branch
from
112fe03
to
61a5f3c
Compare
delner
changed the base branch from
feature/add_event_sample_rate_to_all_integrations
to
0.21-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the
Datadog.configuration.analytics_enabledsetting andDD_TRACE_ANALYTICS_ENABLEDenvironment variable to globally enable and disable trace analytics.If
true, only integrations that aren't explicitly configured tofalsewill activate analytics. Iffalse, only integrations that have been explicitly configured withtruewill activate analytics. If unset (left asnil), only integrations that have been explicitly configured withtruewill activate analytics.Basically this means the global flag can be used to turn on certain integrations which default as
nil(e.g. Rack, Racecar, etc), but will not activate others (such as Excon, Sequel, etc.) Those other integrations will require explicit configuration to activate analytics. By default, all analytics are off.