Add warning log if an integration is incompatible #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
added
core
|
From a quick glance, this looks pretty good. Let me think a little more on this and get back to you soon; thanks for the contribution! |
delner
approved these changes
Apr 1, 2019
There was a problem hiding this comment.
Okay, I feel pretty good about this; looks great! Thanks @ericmustin! 🎉
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #457 . If an integration fails to get patched due to an incompatibility (generally a version issue) there is no indication of this and the tracing will just fail silently.
Per discussion of remediation options in the open issue, this PR adds a conditional
WARNlog on thepatchmethod if the integration is incompatible. I usedclass.namehere to refer to the integration but if there is a more appropriate way to do so please let me know.Also updates
patchable_spec.rbto reflect new logging behavior using the conventions seen elsewhere in the spec.Thanks for taking a look! Let me know if there's any feedback, happy to address anything or open to ideas if there's a better way to approach this!