Change span types for HTTP, web, and some datastore integrations #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
previously approved these changes
May 8, 2019
delner
force-pushed
the
fix/span_types_in_integrations
branch
from
7e6c7af
to
6d64a34
Compare
brettlangdon
approved these changes
May 8, 2019
| @@ -6,7 +6,9 @@ module HTTP | |||
| METHOD = 'http.method'.freeze | |||
| STATUS_CODE = 'http.status_code'.freeze | |||
| TEMPLATE = 'template'.freeze | |||
| TYPE = 'http'.freeze | |||
| TYPE_INBOUND = 'web'.freeze | |||
There was a problem hiding this comment.
nice, I like this distinction "inbound" vs "outbound", makes more sense than "web" vs "http"
This was referenced Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the use of
span.typea bit more consistent, this pull request changes the span types for many integrations:proxywebhttpsqlredis,elasticsearch,mongodb, etc.)This should yield nicer looking "Total Time Spent by Type" graphs in the service view.