Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution and development guide #754

Merged
merged 3 commits into from
May 13, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented May 9, 2019

We'd like to make it easier for our contributors to make contributions, by giving them some guidelines and resources that add clarity to the process.

This pull request adds two documents:

  1. CONTRIBUTING.md which describes the process and criteria for submitting contributions.
  2. DevelopmentGuide.md which describes how-to topics such as writing/running tests, adding new integrations etc...

@delner delner added docs Involves documentation do-not-merge/WIP Not ready for merge labels May 9, 2019
@delner delner requested a review from brettlangdon May 9, 2019 21:49
@delner delner self-assigned this May 9, 2019
@delner delner force-pushed the feature/contributing_and_development_guide branch from 9b3452f to 15e7efb Compare May 9, 2019 21:54
@delner delner force-pushed the feature/contributing_and_development_guide branch from 15e7efb to 6403650 Compare May 10, 2019 19:26
@delner delner removed the do-not-merge/WIP Not ready for merge label May 10, 2019
@delner
Copy link
Contributor Author

delner commented May 10, 2019

First draft is ready to review. There's a lot more we could add to the dev guide, but this might suffice for now.

@delner delner requested review from rochdev, majorgreys and jd May 10, 2019 19:31
Copy link
Member

@rochdev rochdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This well be a great template for other languages to follow as well.

@delner delner changed the base branch from master to 0.24-dev May 13, 2019 19:04
@delner delner merged commit 5bb1a49 into 0.24-dev May 13, 2019
@delner delner added this to the 0.24.0 milestone May 13, 2019
@delner delner deleted the feature/contributing_and_development_guide branch May 20, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants