Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for Ruby 1.9 #771

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Deprecate support for Ruby 1.9 #771

merged 1 commit into from
Jun 27, 2019

Conversation

delner
Copy link
Contributor

@delner delner commented Jun 26, 2019

As a first step to dropping support for Ruby 1.9, this pull request adds a deprecation warning that fires only once when users invoke Datadog.configure.

The plan is to:

  • 0.25.0: Deprecate and warn of use of Ruby 1.9
  • 0.26.0: Last version to support Ruby 1.9. Will only backport and release critical bugfixes via 0.26-stable maintenance branch.
  • 0.27.0: Drop Ruby 1.9 support. Bump Ruby version requirement in gempsec to 2.0.

@delner delner added the core Involves Datadog core libraries label Jun 26, 2019
@delner delner added this to the 0.25.0 milestone Jun 26, 2019
@delner delner requested a review from brettlangdon June 26, 2019 16:45
@delner delner self-assigned this Jun 26, 2019
brettlangdon
brettlangdon approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the failing CI, this lgtm

@delner delner force-pushed the refactor/deprecate_ruby_1.9 branch 4 times, most recently from 824a26b to f65bc4a Compare June 27, 2019 19:33
@delner delner force-pushed the refactor/deprecate_ruby_1.9 branch from f65bc4a to b42d437 Compare June 27, 2019 19:45
@delner delner merged commit 9fdb0ad into 0.25-dev Jun 27, 2019
@delner delner deleted the refactor/deprecate_ruby_1.9 branch June 27, 2019 20:04
@delner delner mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@delner delner

Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delner @brettlangdon