Remove deprecated Datadog::HTTPTransport #782
Conversation
delner
added
breaking-change
| @@ -1,101 +0,0 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Removed this integration test since it overlaps with the HTTP adapter integration tests, which are responsible for tagging the request with the correct HTTP headers. Hence, this is considered obsolete.
| @@ -1,64 +0,0 @@ | |||
| require 'spec_helper' | |||
There was a problem hiding this comment.
Removed this integration test since it overlaps with the HTTP adapter integration tests, which are responsible for tagging the request with the correct HTTP headers. Hence, this is considered obsolete.
| require 'ddtrace/transport/http' | ||
| require 'ddtrace/transport/http/adapters/net' | ||
|
|
||
| RSpec.describe 'Adapters::Net integration tests' do |
There was a problem hiding this comment.
Were these missing before or transplanted from removed spec files?
There was a problem hiding this comment.
They never existed: we had similar specs in meta_header_spec.rb and http_integration_spec.rb but none that explicitly tested Net::HTTP adapter in such a way.
In #628, we refactored the transport layer in which we added a new
Datadog::Transport::HTTP::Clientand deprecated the oldDatadog::HTTPTransport.In keeping with our plans to deprecate, this pull request removes the old
Datadog::HTTPTransportentirely, for the 0.26.0 release.