Move span resource name to method #811
Conversation
…urce-name Move resource name to method
|
Looks good @giancarlocosta! You'll likely get a green build after that 👍 |
marcotc
added
community
|
@marcotc Thanks! Looks good now except for |
|
@giancarlocosta Don't worry about |
|
Just one small thing: we want our PRs to be based on the latest unreleased version branch, which currently is |
| @@ -72,6 +72,10 @@ def service_name(env) | |||
| options[:service_name] | |||
| end | |||
|
|
|||
| def resource_name(env) | |||
There was a problem hiding this comment.
@giancarlocosta I think this seems totally fine: what's the motivation for doing so? I imagine you want to patch/override this to customize resource names?
There was a problem hiding this comment.
@delner Yeah that's the goal! 👍
There was a problem hiding this comment.
@giancarlocosta Okay, if that's the case, I think that's totally fine, but keep in mind that this component is not considered a part of the public API and therefore might be subject to change in the future without warning. Just want to make sure that risk is understood and acceptable given such a change might break your instrumentation.
|
@giancarlocosta We'll consider this for our next minor release, which usually happen on Tuesdays. We will sometimes skip a Tuesday if we don't think we have enough substantial changes to ship. |
Name span resource via method, similar to the service_name method.