Rack: Accept generic X-Request-Start header

[JamesHarker]

This patch makes the t= portion of the X-Request-Start header optional so that the request queuing time can be supported on platforms like Heroku.

[marcotc]

Thank you for this PR, and welcome @JamesHarker!

I noticed that Heroku's documentation mentions that time is represented in milliseconds.

Our current implementation calls Time.at(time_value), which expects time in seconds, which is what nginx uses.

To handle Heroku headers correctly, a conversion has to be made here.

[JamesHarker]

I noticed that Heroku's documentation mentions that time is represented in milliseconds.

Our current implementation calls Time.at(time_value), which expects time in seconds, which is what nginx uses.

To handle Heroku headers correctly, a conversion has to be made here.

Apologies, completely overlooked that. I'll update the PR 👍

[JamesHarker]

@marcotc I've updated the PR as requested. I've also added support for Apache as apparently the default there is something different again 🙄

I've added some more tests but I'm not sure if this if this is OTT? Happy to amend if needs be.

I think I've also forked (and have the PR merging into) the wrong branch - would you like me to change this?

[marcotc]

Great work @JamesHarker!
The apache support is super welcome too, thank you.

I left a few more comments, but it's looking pretty close to .

[marcotc]

Thank you very much @JamesHarker for your responsiveness and a solid PR 🎉

[marcotc]

Only a few housekeeping things left to do: address Rubocop issues and sync with master branch.

[JamesHarker]

@JamesHarker The fix to the MongoDB test failure you are seeing in your build is in master branch. Sync with master and you are good!

Master merged back in so I think we're good go? 👍

[marcotc]

All ✅, thank you!