-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broader CI bundler cache #841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
added
dev/testing
Involves testing processes (e.g. RSpec)
ci-cache-dependencies
labels
Oct 16, 2019
Thanks for this @marcotc! I'll give this a review in a bit, but those results look promising! |
I added |
delner
previously approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
delner
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #821
This PR adds an extra caching layer to the local gem cache,
/usr/local/bundle
, that is able to be re-utilized across different CI builds.The caching key needs to only depends on information available before
bundle install
andappraisal install
are run. This rules out the checksum of gem lock files.With this in mind, this caching key was chosen:
It varies by: Ruby version, dd-trace-rb version, git branch name, contents of Gemfile, Appraisals, and ddtrace.gemspec.
It can also be arbitrarily invalidated at any point by setting a different
CIRCLE_CACHE_VERSION
environment variable in our CI pipeline.When restoring this cache key, we try a few combinations:
Gemfile
andAppraisals
files. Caching content is still good, as all unchanged dependencies are likely the same.This fallback strategy guarantees the only build that runs without any gem caching is a version bump (or manual cache invalidation through
CIRCLE_CACHE_VERSION
).For reference, the current cache persistency layer we have is used to propagate installed dependencies to downstream jobs (e.g CI
test
steps,) and speeds up CI workflow reruns.It is very precisely matched to the current build environment, depending on the checksum of all gemlock files.
Given it depends on gemlocks files, that are only available after gem installation, it cannot be used to speed up such operation.
Some results
Before:
After:
(~ 1-2 minute reduction)